Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[9.x] Fix database tests #44704

Merged
merged 2 commits into from
Oct 24, 2022
Merged

[9.x] Fix database tests #44704

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6b5f5c
Fix database tests
driesvints Oct 24, 2022
8236395
Test multiple scenarios
driesvints Oct 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
201 changes: 146 additions & 55 deletions tests/Database/DatabaseSchemaBlueprintIntegrationTest.php
View file
Open in desktop
Expand Up @@ -84,6 +84,18 @@ public function testRenamingAndChangingColumnsWork()
'INSERT INTO users (first_name, age) SELECT name, age FROM __temp__users',
'DROP TABLE __temp__users',
],
[
'CREATE TEMPORARY TABLE __temp__users AS SELECT name, age FROM users',
'DROP TABLE users',
'CREATE TABLE users (name VARCHAR(255) NOT NULL COLLATE "BINARY", age INTEGER NOT NULL)',
'INSERT INTO users (name, age) SELECT name, age FROM __temp__users',
'DROP TABLE __temp__users',
'CREATE TEMPORARY TABLE __temp__users AS SELECT name, age FROM users',
'DROP TABLE users',
'CREATE TABLE users (first_name VARCHAR(255) NOT NULL, age VARCHAR(255) NOT NULL COLLATE "BINARY")',
'INSERT INTO users (first_name, age) SELECT name, age FROM __temp__users',
'DROP TABLE __temp__users',
],
];

$this->assertContains($queries, $expected);
Expand All @@ -104,26 +116,46 @@ public function testChangingColumnWithCollationWorks()
});

$queries = $blueprint->toSql($this->db->connection(), new SQLiteGrammar);
$queries2 = $blueprint2->toSql($this->db->connection(), new SQLiteGrammar);

$expected = [
'CREATE TEMPORARY TABLE __temp__users AS SELECT age FROM users',
'DROP TABLE users',
'CREATE TABLE users (age INTEGER NOT NULL COLLATE RTRIM)',
'INSERT INTO users (age) SELECT age FROM __temp__users',
'DROP TABLE __temp__users',
[
'CREATE TEMPORARY TABLE __temp__users AS SELECT age FROM users',
'DROP TABLE users',
'CREATE TABLE users (age INTEGER NOT NULL COLLATE RTRIM)',
'INSERT INTO users (age) SELECT age FROM __temp__users',
'DROP TABLE __temp__users',
],
[
'CREATE TEMPORARY TABLE __temp__users AS SELECT age FROM users',
'DROP TABLE users',
'CREATE TABLE users (age INTEGER NOT NULL COLLATE "RTRIM")',
'INSERT INTO users (age) SELECT age FROM __temp__users',
'DROP TABLE __temp__users',
],
];

$expected2 = [
'CREATE TEMPORARY TABLE __temp__users AS SELECT age FROM users',
'DROP TABLE users',
'CREATE TABLE users (age INTEGER NOT NULL COLLATE NOCASE)',
'INSERT INTO users (age) SELECT age FROM __temp__users',
'DROP TABLE __temp__users',
$this->assertContains($queries, $expected);

$queries = $blueprint2->toSql($this->db->connection(), new SQLiteGrammar);

$expected = [
[
'CREATE TEMPORARY TABLE __temp__users AS SELECT age FROM users',
'DROP TABLE users',
'CREATE TABLE users (age INTEGER NOT NULL COLLATE NOCASE)',
'INSERT INTO users (age) SELECT age FROM __temp__users',
'DROP TABLE __temp__users',
],
[
'CREATE TEMPORARY TABLE __temp__users AS SELECT age FROM users',
'DROP TABLE users',
'CREATE TABLE users (age INTEGER NOT NULL COLLATE "NOCASE")',
'INSERT INTO users (age) SELECT age FROM __temp__users',
'DROP TABLE __temp__users',
],
];

$this->assertEquals($expected, $queries);
$this->assertEquals($expected2, $queries2);
$this->assertContains($queries, $expected);
}

public function testChangingCharColumnsWork()
Expand All @@ -139,14 +171,23 @@ public function testChangingCharColumnsWork()
$queries = $blueprint->toSql($this->db->connection(), new SQLiteGrammar);

$expected = [
'CREATE TEMPORARY TABLE __temp__users AS SELECT name FROM users',
'DROP TABLE users',
'CREATE TABLE users (name CHAR(50) NOT NULL COLLATE BINARY)',
'INSERT INTO users (name) SELECT name FROM __temp__users',
'DROP TABLE __temp__users',
[
'CREATE TEMPORARY TABLE __temp__users AS SELECT name FROM users',
'DROP TABLE users',
'CREATE TABLE users (name CHAR(50) NOT NULL COLLATE BINARY)',
'INSERT INTO users (name) SELECT name FROM __temp__users',
'DROP TABLE __temp__users',
],
[
'CREATE TEMPORARY TABLE __temp__users AS SELECT name FROM users',
'DROP TABLE users',
'CREATE TABLE users (name CHAR(50) NOT NULL COLLATE "BINARY")',
'INSERT INTO users (name) SELECT name FROM __temp__users',
'DROP TABLE __temp__users',
],
];

$this->assertEquals($expected, $queries);
$this->assertContains($queries, $expected);
}

public function testChangingDoubleColumnsWork()
Expand Down Expand Up @@ -234,15 +275,25 @@ public function testAddUniqueIndexWithoutNameWorks()
$queries = $blueprintMySql->toSql($this->db->connection(), new MySqlGrammar);

$expected = [
'CREATE TEMPORARY TABLE __temp__users AS SELECT name FROM users',
'DROP TABLE users',
'CREATE TABLE users (name VARCHAR(255) DEFAULT NULL COLLATE BINARY)',
'INSERT INTO users (name) SELECT name FROM __temp__users',
'DROP TABLE __temp__users',
'alter table `users` add unique `users_name_unique`(`name`)',
[
'CREATE TEMPORARY TABLE __temp__users AS SELECT name FROM users',
'DROP TABLE users',
'CREATE TABLE users (name VARCHAR(255) DEFAULT NULL COLLATE BINARY)',
'INSERT INTO users (name) SELECT name FROM __temp__users',
'DROP TABLE __temp__users',
'alter table `users` add unique `users_name_unique`(`name`)',
],
[
'CREATE TEMPORARY TABLE __temp__users AS SELECT name FROM users',
'DROP TABLE users',
'CREATE TABLE users (name VARCHAR(255) DEFAULT NULL COLLATE "BINARY")',
'INSERT INTO users (name) SELECT name FROM __temp__users',
'DROP TABLE __temp__users',
'alter table `users` add unique `users_name_unique`(`name`)',
],
];

$this->assertEquals($expected, $queries);
$this->assertContains($queries, $expected);

$blueprintPostgres = new Blueprint('users', function ($table) {
$table->string('name')->nullable()->unique()->change();
Expand All @@ -251,15 +302,25 @@ public function testAddUniqueIndexWithoutNameWorks()
$queries = $blueprintPostgres->toSql($this->db->connection(), new PostgresGrammar);

$expected = [
'CREATE TEMPORARY TABLE __temp__users AS SELECT name FROM users',
'DROP TABLE users',
'CREATE TABLE users (name VARCHAR(255) DEFAULT NULL COLLATE BINARY)',
'INSERT INTO users (name) SELECT name FROM __temp__users',
'DROP TABLE __temp__users',
'alter table "users" add constraint "users_name_unique" unique ("name")',
[
'CREATE TEMPORARY TABLE __temp__users AS SELECT name FROM users',
'DROP TABLE users',
'CREATE TABLE users (name VARCHAR(255) DEFAULT NULL COLLATE BINARY)',
'INSERT INTO users (name) SELECT name FROM __temp__users',
'DROP TABLE __temp__users',
'alter table "users" add constraint "users_name_unique" unique ("name")',
],
[
'CREATE TEMPORARY TABLE __temp__users AS SELECT name FROM users',
'DROP TABLE users',
'CREATE TABLE users (name VARCHAR(255) DEFAULT NULL COLLATE "BINARY")',
'INSERT INTO users (name) SELECT name FROM __temp__users',
'DROP TABLE __temp__users',
'alter table "users" add constraint "users_name_unique" unique ("name")',
],
];

$this->assertEquals($expected, $queries);
$this->assertContains($queries, $expected);

$blueprintSQLite = new Blueprint('users', function ($table) {
$table->string('name')->nullable()->unique()->change();
Expand All @@ -268,15 +329,25 @@ public function testAddUniqueIndexWithoutNameWorks()
$queries = $blueprintSQLite->toSql($this->db->connection(), new SQLiteGrammar);

$expected = [
'CREATE TEMPORARY TABLE __temp__users AS SELECT name FROM users',
'DROP TABLE users',
'CREATE TABLE users (name VARCHAR(255) DEFAULT NULL COLLATE BINARY)',
'INSERT INTO users (name) SELECT name FROM __temp__users',
'DROP TABLE __temp__users',
'create unique index "users_name_unique" on "users" ("name")',
[
'CREATE TEMPORARY TABLE __temp__users AS SELECT name FROM users',
'DROP TABLE users',
'CREATE TABLE users (name VARCHAR(255) DEFAULT NULL COLLATE BINARY)',
'INSERT INTO users (name) SELECT name FROM __temp__users',
'DROP TABLE __temp__users',
'create unique index "users_name_unique" on "users" ("name")',
],
[
'CREATE TEMPORARY TABLE __temp__users AS SELECT name FROM users',
'DROP TABLE users',
'CREATE TABLE users (name VARCHAR(255) DEFAULT NULL COLLATE "BINARY")',
'INSERT INTO users (name) SELECT name FROM __temp__users',
'DROP TABLE __temp__users',
'create unique index "users_name_unique" on "users" ("name")',
],
];

$this->assertEquals($expected, $queries);
$this->assertContains($queries, $expected);

$blueprintSqlServer = new Blueprint('users', function ($table) {
$table->string('name')->nullable()->unique()->change();
Expand All @@ -285,15 +356,25 @@ public function testAddUniqueIndexWithoutNameWorks()
$queries = $blueprintSqlServer->toSql($this->db->connection(), new SqlServerGrammar);

$expected = [
'CREATE TEMPORARY TABLE __temp__users AS SELECT name FROM users',
'DROP TABLE users',
'CREATE TABLE users (name VARCHAR(255) DEFAULT NULL COLLATE BINARY)',
'INSERT INTO users (name) SELECT name FROM __temp__users',
'DROP TABLE __temp__users',
'create unique index "users_name_unique" on "users" ("name")',
[
'CREATE TEMPORARY TABLE __temp__users AS SELECT name FROM users',
'DROP TABLE users',
'CREATE TABLE users (name VARCHAR(255) DEFAULT NULL COLLATE BINARY)',
'INSERT INTO users (name) SELECT name FROM __temp__users',
'DROP TABLE __temp__users',
'create unique index "users_name_unique" on "users" ("name")',
],
[
'CREATE TEMPORARY TABLE __temp__users AS SELECT name FROM users',
'DROP TABLE users',
'CREATE TABLE users (name VARCHAR(255) DEFAULT NULL COLLATE "BINARY")',
'INSERT INTO users (name) SELECT name FROM __temp__users',
'DROP TABLE __temp__users',
'create unique index "users_name_unique" on "users" ("name")',
],
];

$this->assertEquals($expected, $queries);
$this->assertContains($queries, $expected);
}

public function testAddUniqueIndexWithNameWorks()
Expand All @@ -309,15 +390,25 @@ public function testAddUniqueIndexWithNameWorks()
$queries = $blueprintMySql->toSql($this->db->connection(), new MySqlGrammar);

$expected = [
'CREATE TEMPORARY TABLE __temp__users AS SELECT name FROM users',
'DROP TABLE users',
'CREATE TABLE users (name VARCHAR(255) DEFAULT NULL COLLATE BINARY)',
'INSERT INTO users (name) SELECT name FROM __temp__users',
'DROP TABLE __temp__users',
'alter table `users` add unique `index1`(`name`)',
[
'CREATE TEMPORARY TABLE __temp__users AS SELECT name FROM users',
'DROP TABLE users',
'CREATE TABLE users (name VARCHAR(255) DEFAULT NULL COLLATE BINARY)',
'INSERT INTO users (name) SELECT name FROM __temp__users',
'DROP TABLE __temp__users',
'alter table `users` add unique `index1`(`name`)',
],
[
'CREATE TEMPORARY TABLE __temp__users AS SELECT name FROM users',
'DROP TABLE users',
'CREATE TABLE users (name VARCHAR(255) DEFAULT NULL COLLATE "BINARY")',
'INSERT INTO users (name) SELECT name FROM __temp__users',
'DROP TABLE __temp__users',
'alter table `users` add unique `index1`(`name`)',
],
];

$this->assertEquals($expected, $queries);
$this->assertContains($queries, $expected);

$blueprintPostgres = new Blueprint('users', function ($table) {
$table->unsignedInteger('name')->nullable()->unique('index1')->change();
Expand Down