[9.x] Add method to remove a middleware from a group #44780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Magic Test, I need to dynamically register a middleware and in some situations that middleware needs to also be removed.
The current way is rebinding the middleware in the container to an implementation that doesn't really do anything. I think having the ability to remove it from a group is a cleaner way to do it, and since you can already rebind dependencies on the container I don't think it'd be a problem.
P.S: this PR also includes some tests for
pushMiddlewareToGroup, in case it isn't accepted I can send it on a separate PR.Also: I wasn't sure if I should use types or not on this PR since it is aimed at v9, but I can add them if necessary. 👍