Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[9.x] Validate uuid before route binding query #44945

Merged
merged 8 commits into from
Nov 21, 2022
Merged

[9.x] Validate uuid before route binding query #44945

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b085571
validate uuid before route binding query
benbjurstrom Nov 14, 2022
6ce6ee5
Update HasUuids.php
taylorotwell Nov 15, 2022
9e9e0cd
Update HasUuids.php
taylorotwell Nov 15, 2022
3e8406e
validate uuid in resolveRouteBindingQuery
benbjurstrom Nov 17, 2022
d551c68
validate uuid if field in uniqueIds
benbjurstrom Nov 18, 2022
dabb30f
styleci changes
benbjurstrom Nov 18, 2022
e06a7c2
drop comments table
benbjurstrom Nov 18, 2022
5651cdc
formatting
taylorotwell Nov 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions src/Illuminate/Database/Eloquent/Concerns/HasUuids.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

namespace Illuminate\Database\Eloquent\Concerns;

use Illuminate\Database\Eloquent\ModelNotFoundException;
use Illuminate\Support\Str;

trait HasUuids
Expand Down Expand Up @@ -69,4 +70,22 @@ public function getIncrementing()

return $this->incrementing;
}

/**
* Retrieve the model for a bound value.
*
* @param mixed $value
* @param string|null $field
* @return \Illuminate\Database\Eloquent\Model|null
*/
public function resolveRouteBinding($value, $field = null)
{
if (in_array($this->getRouteKeyName(), $this->uniqueIds())) {
if (!Str::isUuid($value)) {
throw (new ModelNotFoundException)->setModel(get_class($this), $value);
}
}

return parent::resolveRouteBinding($value);
}
}