[9.x] Add whenMissing() method to InteractsWithInput trait #45019
Merged
Conversation
foremtehan
reviewed
Nov 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
InteractsWithInputmethodshas()andfilled()both have a syntactic sugar methodwhenHas()andwhenFilled()that accepts a callback to avoid addingif's.This PR adds the method
whenMissing()that is basically the opposite ofwhenHas().Today I was working on a middleware that takes care of both mappings and default fields. That looked something like this:
However, sometimes you need to add a little more than just the additional fields. Could be something like notifying a 3rd part service that this part of the API is still getting used:
I just think it's a nice little syntactic sugar.