Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct PHPDoc for the HTTP-client transferStats property #45267

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

AJenbo
Copy link
Contributor

@AJenbo AJenbo commented Dec 12, 2022

IDEs and analyzers are unable to determine the type of the property. Correcting the PHPDoc provides better feedback for developers. This is a simple change to a comment block and should not break anything.

Failed test not related to these PR changes, see #45251

@AJenbo AJenbo marked this pull request as draft December 12, 2022 00:42
@AJenbo AJenbo marked this pull request as ready for review December 12, 2022 00:45
@driesvints driesvints marked this pull request as draft December 12, 2022 08:01
@driesvints driesvints marked this pull request as ready for review December 12, 2022 08:05
@driesvints driesvints merged commit 3480b7c into laravel:9.x Dec 12, 2022
@driesvints
Copy link
Member

Thanks!

@AJenbo AJenbo deleted the patch-2 branch December 12, 2022 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants