Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.x] Add streamed content test assertion #45298

Merged
merged 3 commits into from Dec 14, 2022
Merged

[9.x] Add streamed content test assertion #45298

merged 3 commits into from Dec 14, 2022

Conversation

ziadoz
Copy link
Contributor

@ziadoz ziadoz commented Dec 14, 2022

This PR of mine was merged but then reverted because the tests were broken (sorry!). This PR fixes the tests.

❯ ./bin/test.sh -- --filter=TestResponseTest
Ensuring docker is running
Ensuring services are running
laravel-framework_redis_1 is up-to-date
laravel-framework_mysql_1 is up-to-date
laravel-framework_memcached_1 is up-to-date
laravel-framework_dynamodb_1 is up-to-date
Running tests
PHPUnit 9.5.27 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.0.26
Configuration: /data/phpunit.xml.dist

...............................................................  63 / 138 ( 45%)
............................................................... 126 / 138 ( 91%)
............                                                    138 / 138 (100%)

Time: 00:00.236, Memory: 100.50 MB

OK (138 tests, 395 assertions)

@ziadoz ziadoz marked this pull request as ready for review December 14, 2022 10:25
@taylorotwell taylorotwell merged commit 2181f38 into laravel:9.x Dec 14, 2022
taylorotwell pushed a commit to laravel/docs that referenced this pull request Dec 14, 2022
@ziadoz ziadoz deleted the assert-streamed-content branch December 21, 2022 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants