[9.x] Return model when casting attribute#45539
Merged
taylorotwell merged 1 commit into9.xfrom Jan 6, 2023
Merged
Conversation
driesvints
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, when setting an attribute directly through
setAttributethat has an Attribute cast, it won't return anything while the behavior of all the other calls tosetAttributeis to return the model. Given that the return ofsetAttributeMarkedMutatedAttributeValueismixedbut nothing was returned, it seems to me that this was forgotten.setMutatedAttributeValuealso doesn't explicitly returns the model but people can decide for themselves to do that or not in the mutator.Fixes #45537