Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[9.x] Optimize findMany of BelongsToMany 🏃🏻‍♂️ #45745

Merged
merged 1 commit into from
Jan 22, 2023
Merged

[9.x] Optimize findMany of BelongsToMany 🏃🏻‍♂️ #45745

merged 1 commit into from
Jan 22, 2023

Conversation

imanghafoori1
Copy link
Contributor

@imanghafoori1 imanghafoori1 commented Jan 20, 2023 •
edited
Loading

Since whereKey uses the whereIntegerInRaw it would be better to use it.
This PR applies it on touch and findMany methods.

  • Also adds integration tests for models with stringy primary key.

@imanghafoori1 imanghafoori1 force-pushed the optimize_find_many branch 2 times, most recently from b415d83 to ba7b9c1 Compare January 20, 2023 17:03
@taylorotwell taylorotwell marked this pull request as draft January 20, 2023 19:12
@imanghafoori1 imanghafoori1 marked this pull request as ready for review January 20, 2023 21:20
@imanghafoori1 imanghafoori1 changed the title [9.x] Optimize findMany of BelongsToMany [9.x] Optimize findMany of BelongsToMany 🏃🏻‍♂️ Jan 20, 2023
@taylorotwell taylorotwell merged commit 007c85b into laravel:9.x Jan 22, 2023
@imanghafoori1 imanghafoori1 deleted the optimize_find_many branch January 23, 2023 07:36
@GrahamCampbell GrahamCampbell mentioned this pull request Mar 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taylorotwell taylorotwell taylorotwell left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@imanghafoori1 @taylorotwell