[9.x] Restart syscalls for SIGALRM when worker times out a job #45871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add a thorough description at what this fixes for the person that will review this PR and not link to an issue (see the PR template). |
|
Updated @driesvints |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #45867 whenever a
SIGALRMhappens during an execution of a query a PDOException gets thrown from the MSSql server. In simpler terms, wheneverSIGALRMarrives the MSSQL connection gets broken resulting in the query not being to execute itself, hence throwing the error.Although
restart_syscallsargument is true by default inpcntl_signalthis will not work withSIGALRMsignal due to the backwards compatibility left by Nikita Popov in this commit.