[9.x] Fixes blade escaped tags issue - #45928
Merged
Merged
Conversation
imanghafoori1
force-pushed
the
fix_45915
branch
2 times, most recently
from
February 2, 2023 20:26
41e2573 to
68181c6
Compare
imanghafoori1
force-pushed
the
fix_45915
branch
from
February 2, 2023 20:31
68181c6 to
111626e
Compare
Member
|
Are all these substr_replace, strlen calls going to work if there are multi-byte characters in the template? |
Contributor
Author
|
@taylorotwell I will design some tests for those cases. |
Contributor
Author
|
@taylorotwell It works ok with emojis or other 3-bit chars but it needs some testing, because if someone changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #45915
In the added test there are 4 matches, in the second replacement
@@endforeachwith@endforeachin the second replacement.Then the final replacement searches for
@endforeachto replace it with the compiled version, but it finds what was produced by the previously escaped tag because it starts the search from the beginning of the string.Solution:
Logically when replacing the matches found by REGEX one after the other using
Str::replaceFirst, we have to continue from where we last left off.