New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.2] Support/Array : add Arr class #4620
Conversation
👍 |
#3537 was turned down. Might want to better describe the need for this. |
It was closed but honestly I'm not sure why as this had been agreed upon previously. |
👍 |
Good catch @barryvdh , squashed and commited |
Oh I see now that the Str classes also didn't do that (don't know why). But cool, I don't think the Laravel core should be dependent on all those helpers. |
I really like this. 👍 |
@crynobone one advantage to using a class would be for splitting a complex function into multiple methods. See this thread for an example. |
* @param \CLosure $callback | ||
* @return array | ||
*/ | ||
static function build($array, \CLosure $callback) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CLosure
typo there.
Can you look at the merge conflicts on this? |
Done and squashed @taylorotwell |
That commit name is pretty bad... |
@taylorotwell , is everything good for this PR ? |
[4.2] Support/Array : add Arr class
Move
array_*
functions fromhelpers.php
to newArr
class.(just following the way it has been done for string functions in
Str
class)