[10.x] Fix custom themes not reseting on Markdown renderer #46200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like it's setting the theme always to |
|
@AEM5299 we'll need to fix that. Can you provide a follow up PR? |
|
Opened PR #46317. |
taylorotwell
added a commit
that referenced
this pull request
Mar 2, 2023
|
We've decided to revert this PR for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue described in #46179. It should reset the theme to
'default'on the Markdown renderer object if no$themeis set on theMailableobject. I've also added a test for this. This PR does not introduce any breaking changes.There's a small inconsistency between
MailableandMarkdownclasses, theMailableclass has a default$themevalue ofnull(implicitly the default theme), howeverMarkdownhas a default theme value of'default'(here and here). But fixing this inconsistency might be a breaking change, so not sure if you'd want to fix it.