[10.x] Accept time when generating ULID #46201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This makes the method return a string instead of a ULID object, which is a breaking change. |
|
Mark this as ready for review if you want me to look again. |
|
Thanks, @taylorotwell, good catch! I've updated this PR to always return a ULID object. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
Str::ulid()doesn't accept a time, although the underlying Symfony class does have ageneratemethod that does accept it.When migrating models from integer IDs to ULIDs, it's nice if you can keep the creation timestamp in the ULID.
This PR enables that.
Not sure what laravel/framework uses for type declarations, so let me know if anything needs changing.