[10.x] Fix infinite loading on batches list on Horizon #46536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As described on this issue: laravel/horizon#1259 If a model is deleted while it still exists on the batches list (serialized), it will cause the batches list to be broken. The reason for this is that when the unserialize function is called, it tries to invoke the __unserialize() or __wakeup() methods automatically, and if the model does not exist, an exception is thrown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described on this issue: laravel/horizon#1259
If a model is deleted while it still exists on the batches list (serialized), it will cause the batches list to be broken.
The reason for this is that when the unserialize function is called, it tries to invoke the __unserialize() or __wakeup() methods automatically, and if the model does not exist, an exception is thrown.