[10.x] console.stub: remove void return type from handle #46697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return type of a command can be the status code as int. The void type suggests that there is no return type expected. This made me search through code and documentation to check if there's now a different way of passing the exit code. Hence to avoid confusion I suggest to remove the void type and let the user decide later, if it should be void or int.
|
I was going to send similar pr, but with |
apreiml
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return type of a command can be the status code as int. The void type suggests that there is no return type expected. This made me search through code and documentation to check if there's now a different way of passing the exit code.
Hence to avoid confusion I suggest to remove the void type and let the user decide later, if it should be void or int.