[9.x] Release lock for job implementing ShouldBeUnique that is dispatched afterResponse()

[cosmastech]

To resolve #46537

• Changed Dispatchable@dispatchAfterResponse() so that PendingDispatch@shouldDispatch() checks for lock, rather than just pushing immediately to the Application::$terminatingCallbacks array. Could move this to a separate PR, as maybe you would consider it a breaking change. Seems kind of strange that Job::dispatchAfterResponse() doesn't check for uniqueness, but Job::dispatch()->afterResponse() does.
• Moves the handling of middleware/unique locks out of CallQueuedHandler@call() to its own method CallQueuedHandler@handle(). I named the method handle() so that it could be more easily used with Bus\Dispatcher@dispatchNow() (which is expecting the $handler argument to implement either __invoke() or handle().
  • I think normally I would move this to its own action class or something, but really wanted to make as few changes as possible to get this working.

Jobs dispatched after response should now also be routed through middleware as well. Might make sense to add a test case for that, just let me know.

[taylorotwell]

Is this not as simple as just changing dispatchAfterResponse on the Bus Dispatcher to use dispatchSync instead of dispatchNow?

dispatchNow is not recommended and is quasi deprecated because of the fact that it doesn't apply middleware, etc. That simple change fixes the issue for me.

public function dispatchAfterResponse($command, $handler = null)
{
    $this->container->terminating(function () use ($command, $handler) {
        $this->dispatchSync($command, $handler);
    });
}

[cosmastech]

Is this not as simple as just changing dispatchAfterResponse on the Bus Dispatcher to use dispatchSync instead of dispatchNow?

dispatchNow is not recommended and is quasi deprecated because of the fact that it doesn't apply middleware, etc. That simple change fixes the issue for me.

You're right.

I've reverted the other changes I made, though I kept the change to Dispatchable::dispatchAfterResponse(). Without it, there's never a call to PendingDispatch@shouldDispatch()

Tweaked the test cases slightly to use both Job::dispatch()->afterResponse() and Job::dispatchAfterResponse();