[10.x] Add withQueryParameters to the HTTP client

[mnapoli]

Some APIs require some query parameters to be always set. For example auth token (even though this isn't a great practice).

With this new helper, we can create a macro with the query parameter always set.

Example:

        Http::macro('convertKit', fn() => Http::timeout(5)
            ->retry(3, 100)
            ->withOptions([
                'query' => [
                    'api_secret' => config('services.convertkit.api_secret'),
                ],
            ])
            ->baseUrl('https://api.convertkit.com/v3/')
            ->acceptJson());

can become:

        Http::macro('convertKit', fn() => Http::timeout(5)
            ->retry(3, 100)
            ->withQueryParameters([
                'api_secret' => config('services.convertkit.api_secret'),
            ])
            ->baseUrl('https://api.convertkit.com/v3/')
            ->acceptJson());

[cosmastech]

Http::convertKit()->get('users', ['search' => 'Matthieu']);

Will this code overwrite the query specified in the macro?

[mnapoli]

@cosmastech good question, only one way to find out. I added a new test to the PR, the query parameters are merged together 👍

[taylorotwell]

@mnapoli what about some tests to confirm behavior around arrays? For example:

$this->factory->withQuery(
    ['foo' => ['bar', 'baz']],
)->get('https://laravel.com');

And other related scenarios.

Can you mark as ready for review again when that is done? Thanks!

[driesvints]

@mnapoli are you still working on this?

[mnapoli]

@driesvints apologies for the delay, I added more tests to cover these behaviors:

• we can set query parameters with the new methods
• on ->get(), we can set additional parameters or override previously set parameters

This is the behavior I would expect and I think makes sense, let me know if you think otherwise.