[10.x] Allow serialization of NotificationSent #47375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taylorotwell
reviewed
Jun 8, 2023
| 'data' => base64_encode(serialize($this->data)), | ||
| 'hasAttachments' => true, | ||
| ] : [ | ||
| return [ | ||
| 'sent' => $this->sent, |
There was a problem hiding this comment.
This never needs to be base 64 encoded and serialized anymore?
There was a problem hiding this comment.
Admittedly, I don't know all of the use cases here, but my thinking is: if SentMessage is being base64_encoded for attachments when it is serialized, then there's no need to encode it again when MessageSent is being serialized.
Do you see a flaw in that thinking?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To close #47372
Test serializing/unserializing MessageSentThis is covered adequately by serializing MessageSent, but can add another test if requested.MessageSent handily serializes and unserializes the raw message data (contained within SentMessage, which relies on Symfony's SentMessage class).
Since Illuminate's SentMessage is common to both MessageSent and NotificationSent, I thought it would make sense to move the base64 encoding/decoding and serialization of Symfony's SentMessage to Laravel's SentMessage class.
BTW, these names are confusing as hell to talk about, let alone work on. 馃槅