Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.x] Fix SES V2 Transport "reply to" addresses #47522

Merged
merged 2 commits into from
Jun 21, 2023

Conversation

jacobmllr95
Copy link
Contributor

When I added the SesV2Transport a few months back, I used the ReplyToAddresses attribute to define the sender of the message. This always set the sender as "reply to" address and prevented user-defined addresses to be applied.

Closes #47512.

@taylorotwell taylorotwell merged commit df9100e into laravel:9.x Jun 21, 2023
20 checks passed
@jacobmllr95 jacobmllr95 deleted the fix-ses-v2-reply-to branch June 22, 2023 02:05
@ArthurGuy
Copy link

How often are new version tags created? i.e. when will this fix be available for use

@GrahamCampbell
Copy link
Member

This fix is already immediately available using dev stability.

@ArthurGuy
Copy link

This is for a service running a production workload so I need to wait for a tagged release.

@dennisprudlo
Copy link
Contributor

Judging by the release dates it seems there is more or less a release every week.

@GrahamCampbell
Copy link
Member

There is no reason to wait for a tagged release. The lock file allows you to be pinned to a specific commit hash.

@ArthurGuy
Copy link

That would require the team always being aware when any other composer update is made so dev changes aren't inadvertently pulled down, and also keeping track of this issue to roll back the version being pinned when it does eventually get tagged.

We are running a product in a regulated space where a lot is at stake, I am sure others might make a different call but it's just not worth the risk to me.

@mfn
Copy link
Contributor

mfn commented Jun 23, 2023

That would require the team always being aware when any other composer update is made so dev changes aren't inadvertently pulled down

I think what he means is that you can nail it down to a commit hash, like so

"laravel/framework": "dev-master#commit-hash-goes-hre"

so every dev pulls the same, there's no risk of mixing this up.

But I can totally related to proper tagged releases and production, not arguing there at all :)

@ArthurGuy
Copy link

Thanks @mfn I didn't realise you could do that, I assumed it was the hash in the lock file that was being referred to.
I will leave it to Monday, just in case, but thats definitely worth exploring as an option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants