Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10.x] update [JsonResponse]: using match expression instead of if-elseif-else #47524

Merged
merged 2 commits into from
Jun 22, 2023
Merged

[10.x] update [JsonResponse]: using match expression instead of if-elseif-else #47524

merged 2 commits into from
Jun 22, 2023

Conversation

saMahmoudzadeh
Copy link
Contributor

Hello!

In this PR, a match expression has been used instead of if-elseif-else statements in the setData method of the JsonResponse class with the goal of improving readability.

Thanks!

@saMahmoudzadeh saMahmoudzadeh marked this pull request as ready for review June 21, 2023 23:31
@taylorotwell taylorotwell merged commit a69c1bd into laravel:10.x Jun 22, 2023
16 checks passed
@saMahmoudzadeh
Copy link
Contributor Author

Thanks @taylorotwell

@saMahmoudzadeh saMahmoudzadeh deleted the JsonResponse branch June 22, 2023 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@saMahmoudzadeh @taylorotwell