Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.x] Allow % symbol in component attribute names #47533

Merged
merged 2 commits into from
Jun 22, 2023

Conversation

JayBizzle
Copy link
Contributor

@JayBizzle JayBizzle commented Jun 22, 2023

Resubmission of #47509 targeting the 10.x branch


I was recently dealing with a component where we wanted to use the Alpine intersect plugin, but soon realised you couldn't do something like this...

<x-component class="font-bold" x-intersect.margin.-50%.0px="visibleSection = 'profile'" />

It seems the Blade component compiler doesn't allow % symbols in attribute names.

Im not sure if there is a reason for this, or if it is an oversight, but I had a go at fixing it, so here it is.

@taylorotwell taylorotwell merged commit 6d584e5 into laravel:10.x Jun 22, 2023
17 checks passed
@JayBizzle JayBizzle deleted the patch-3 branch July 21, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants