[10.x] Adds inline attachments support for "notifications" markdown mailables #47643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[10.x] Support Inline Attachments within Markdown Mailable
…l/framework into fix/markdown-mailable-adjustments
|
@nunomaduro could the buildsMarkdown stuff be moved into a trait to avoid duplication and potentially divergent handling in the future? |
|
@cosmastech They are slightly different internally, so probably keeping it simply like this for now. |
This was referenced Oct 11, 2023
Closed
This was referenced Oct 14, 2023
This was referenced Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based #47603, with some minor adjustments, this pull request completes #47140, by adding support for inline attachments support for "notifications" markdown mailables.
Note that, notifications use a different mail channel from regular mailables, therefore the code needed to be introduced here too.