Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.x] Fixes failing tests running on DynamoDB Local 2.0.0 #47653

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

crynobone
Copy link
Member

No description provided.

@crynobone crynobone marked this pull request as ready for review July 4, 2023 14:52
@crynobone crynobone changed the title Test Improvements Fixes failing tests running on DynamoDB Local 2.0.0 Jul 4, 2023
Copy link
Member

@GrahamCampbell GrahamCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we pin amazon/dynamodb-local:latest to a major version, instead of just latest?

@crynobone
Copy link
Member Author

Don't believe it's possible https://hub.docker.com/r/amazon/dynamodb-local/tags

@GrahamCampbell
Copy link
Member

Maybe just 2.0.0 is fine? Probably we should pin 9.x to 1.22.0, too?

@taylorotwell taylorotwell merged commit 1bf731b into laravel:10.x Jul 4, 2023
17 checks passed
@GrahamCampbell GrahamCampbell changed the title Fixes failing tests running on DynamoDB Local 2.0.0 [10.x] Fixes failing tests running on DynamoDB Local 2.0.0 Jul 4, 2023
@crynobone crynobone deleted the patch-5 branch September 20, 2023 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants