Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10.x] Fix Storage::cloud() return type #47664

Merged
merged 1 commit into from
Jul 5, 2023
Merged

[10.x] Fix Storage::cloud() return type #47664

merged 1 commit into from
Jul 5, 2023

Conversation

tattali
Copy link
Contributor

@tattali tattali commented Jul 5, 2023

The current type \Illuminate\Contracts\Filesystem\Filesystem does not contains the url method

the good type should be \Illuminate\Contracts\Filesystem\Cloud that also extends \Illuminate\Contracts\Filesystem\Filesystem.

Storage::cloud()->url($path); // Actually show Undefined method 'url'.

@tattali tattali changed the title Fix cloud() return type Fix Storage::cloud() return type Jul 5, 2023
@taylorotwell taylorotwell merged commit f631ca8 into laravel:10.x Jul 5, 2023
17 checks passed
@tattali tattali deleted the tattali-cloud-return-type branch July 5, 2023 16:56
@GrahamCampbell GrahamCampbell changed the title Fix Storage::cloud() return type [10.x] Fix Storage::cloud() return type Jul 9, 2023
@BadJacky BadJacky mentioned this pull request Jul 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tattali @taylorotwell