[10.x] Extract customised deleted_at column name from Model FQN #47873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l FCN is passed for table argument
edvordo
deleted the
feature/extract-deleted_at-column-name-from-model-fqn
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request handles an use case an user had in issue #47856
When model FQN is passed, it is still possible to extract / determine whether the SoftDeletes model constant to override the default column name was set and use it in tests for
assertSoftDeletedandassertNotSoftDeleted.Looked like a valid use case to me to support it.
Tests passed locally, but unsure if they are sufficient, I'll gladly welcome feedback / suggestions in case they are not.