[10.x] Fix assertRedirectToRoute when route uri is empty

[khernik93]

Overview

There is a small issue with assertRedirectToRoute adding a trailing slash to the actual redirect url being tested, when the Location header has an empty path, and an existing query string.

Example

Having a route that returns a redirect response, to a route with an empty uri (and at least one parameter):

Route::get('sample-uri', function () {
  return new RedirectResponse(route('route-with-empty-uri', ['foo' => 'bar']));
})->name('perform-redirect');

Route::get('', fn () => 'ok')->name('route-with-empty-uri');

When we try to test the redirection:

$this->get(route('perform-redirect'))
  ->assertRedirectToRoute('route-with-empty-uri', ['foo' => 'bar']);

The actual redirection would be http://localhost?foo=bar, and this is what we expect, but the actual url generated by assertRedirectToRoute is http://localhost/?foo=bar and the test fails.

Problem

It happens due to the $request->fullUrl() adding the trailing slash when both baseUrl and requestUri are empty.

Solution

I changed the:

$request = Request::create($this->headers->get('Location'));

PHPUnit::assertEquals(
    app('url')->to($uri), $request->fullUrl()
);

to:

$this->assertLocation($uri);

which seems to solve the issue and also matches the assertRedirect implementation.