[10.x] Add percentage method to Collections
#48034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I saw that there's one failing check, but I checked the details and it doesn't seem to be related to the changes of the PR. There are also 2 other checks that were cancelled but IDK why. Should I do anything about these? |
cosmastech
reviewed
Aug 11, 2023
|
@cosmastech I updated the PR regarding your observation and also added some more test cases to cover when the percentage should be |
|
Thank you so much for merging this @taylorotwell!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In this PR I add a new method called
percentageto the Collections that allows us to calculate the percentage in a collection based on a truth test.Why
In many apps, we need to calculate percentage values of collections for something, especially when dealing with reports, analytics, metrics etc. Although that's something easy to calculate, doing it manually every time depending on the type of application we build is tiresome.
This method is just a life improvement for the DX, so we don't need to calculate that every time we need.