Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.x] Add broadcastAs function at BroadcastNotificationCreated #48136

Merged
merged 2 commits into from Aug 23, 2023

Conversation

raphaelcangucu
Copy link
Contributor

I add this function so it will get the broadcast event name as the same way it does for other events.

I needed this, because I wanted to specify the event name , and without this function, it will get only the class name.

@cosmastech
Copy link
Contributor

We added something like this to our application within the past month. Would love to see it become a part of the framework.

@raphaelcangucu
Copy link
Contributor Author

We added something like this to our application within the past month. Would love to see it become a part of the framework.

Nice, let's see if gets approved.

@paulojosegamba
Copy link

paulojosegamba commented Aug 22, 2023

Nice one, i needed something like this a few months ago
Had to do it myself hehe

@driesvints driesvints changed the title Add broadcastAs function at BroadcastNotificationCreated, so it will … Add broadcastAs function at BroadcastNotificationCreated Aug 22, 2023
@driesvints driesvints changed the title Add broadcastAs function at BroadcastNotificationCreated [10.x] Add broadcastAs function at BroadcastNotificationCreated Aug 22, 2023
@digitdash
Copy link

Would love to see this added!

@thiago-a-delgado
Copy link

Ow, it would help a lot to have this feature approved!

@taylorotwell taylorotwell merged commit f0bf683 into laravel:10.x Aug 23, 2023
19 of 20 checks passed
@driesvints
Copy link
Member

Going to send in a revert for this because it's a breaking change. We can re-consider this for 11.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants