[10.x] Add broadcastAs function at BroadcastNotificationCreated - #48136
Merged
taylorotwell merged 2 commits intoAug 23, 2023
Conversation
…get from the notification.
Contributor
|
We added something like this to our application within the past month. Would love to see it become a part of the framework. |
Author
Nice, let's see if gets approved. |
|
Nice one, i needed something like this a few months ago |
driesvints
changed the title
driesvints
changed the title
|
Would love to see this added! |
|
Ow, it would help a lot to have this feature approved! |
Member
|
Going to send in a revert for this because it's a breaking change. We can re-consider this for 11.x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I add this function so it will get the broadcast event name as the same way it does for other events.
I needed this, because I wanted to specify the event name , and without this function, it will get only the class name.