Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[slim-skeleton-11.x] Adds Artisan::command(...)->... schedule methods #48137

Merged
merged 3 commits into from
Aug 25, 2023

Conversation

nunomaduro
Copy link
Member

@nunomaduro nunomaduro commented Aug 22, 2023

This pull request continues the work on making the skeleton more "slim", by allowing to chain schedule methods directly on the Artisan::command call. Here is an example, on the console.php:

Artisan::command('inspire', function () {
    $this->comment(Inspiring::quote());
})->purpose('Display an inspiring quote')->hourly();

Optionally, users may also pass "arguments" to the closure command, my prefixing the schedule call to the schedule methods command:

Artisan::command('inspire {name}', function () {
    //
})->purpose('Display an inspiring quote')->schedule(['name' => 'taylor']->hourly();

If this pull request gets merged, here is the following pull request that adjusts this skeleton: laravel/laravel#6230.

@taylorotwell taylorotwell merged commit efa387d into slim-skeleton-11.x Aug 25, 2023
16 of 17 checks passed
@taylorotwell taylorotwell deleted the feat/artisan-command-schedule branch August 25, 2023 13:41
taylorotwell added a commit that referenced this pull request Aug 27, 2023
…ds (#48137)

* Adds `Artisan::command()->schedule(...)`

* Apply fixes from StyleCI

* formatting

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
Co-authored-by: Taylor Otwell <taylor@laravel.com>
taylorotwell added a commit that referenced this pull request Aug 29, 2023
…ds (#48137)

* Adds `Artisan::command()->schedule(...)`

* Apply fixes from StyleCI

* formatting

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
Co-authored-by: Taylor Otwell <taylor@laravel.com>
taylorotwell added a commit that referenced this pull request Sep 6, 2023
…ds (#48137)

* Adds `Artisan::command()->schedule(...)`

* Apply fixes from StyleCI

* formatting

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
Co-authored-by: Taylor Otwell <taylor@laravel.com>
taylorotwell added a commit that referenced this pull request Sep 13, 2023
…ds (#48137)

* Adds `Artisan::command()->schedule(...)`

* Apply fixes from StyleCI

* formatting

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
Co-authored-by: Taylor Otwell <taylor@laravel.com>
taylorotwell added a commit that referenced this pull request Sep 28, 2023
…ds (#48137)

* Adds `Artisan::command()->schedule(...)`

* Apply fixes from StyleCI

* formatting

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
Co-authored-by: Taylor Otwell <taylor@laravel.com>
taylorotwell added a commit that referenced this pull request Oct 2, 2023
…ds (#48137)

* Adds `Artisan::command()->schedule(...)`

* Apply fixes from StyleCI

* formatting

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
Co-authored-by: Taylor Otwell <taylor@laravel.com>
taylorotwell added a commit that referenced this pull request Oct 26, 2023
…ds (#48137)

* Adds `Artisan::command()->schedule(...)`

* Apply fixes from StyleCI

* formatting

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
Co-authored-by: Taylor Otwell <taylor@laravel.com>
taylorotwell added a commit that referenced this pull request Nov 6, 2023
…ds (#48137)

* Adds `Artisan::command()->schedule(...)`

* Apply fixes from StyleCI

* formatting

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
Co-authored-by: Taylor Otwell <taylor@laravel.com>
taylorotwell added a commit that referenced this pull request Nov 28, 2023
…ds (#48137)

* Adds `Artisan::command()->schedule(...)`

* Apply fixes from StyleCI

* formatting

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
Co-authored-by: Taylor Otwell <taylor@laravel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants