[10.x] Fix file race condition after view:cache and artisan up - #48368
Merged
Conversation
roxik
changed the title
roxik
changed the title
Member
|
Please remove all textual formatting / spacing changes made to docblocks and mark as ready for review again when complete. Thanks. |
taylorotwell
marked this pull request as draft
September 12, 2023 21:27
roxik
marked this pull request as ready for review
September 12, 2023 22:43
driesvints
requested changes
Sep 13, 2023
…gMaintenance.php Co-authored-by: Dries Vints <dries@vints.be>
Contributor
Author
|
@driesvints resolved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will fix error with file race condition after call
php artisan view:cacheandphp artisan up.Case
php artisan up:User has request, passed condition
if ($this->app->maintenance Mode()->active())then file framework/down deleted by command and then infile_get_contentswe haveErrorException.Solution: recheck file exists
Case
php artisan view:cache:Same conditions, but instead
file_get_contentswe havefilemtime