Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.x] Test Improvements #48378

Merged
merged 5 commits into from
Sep 13, 2023
Merged

[10.x] Test Improvements #48378

merged 5 commits into from
Sep 13, 2023

Conversation

crynobone
Copy link
Member

@crynobone crynobone commented Sep 13, 2023

There are some limitations when testing generators commands at the moment mainly due to class_exists() is not as reliable as is_file() in some conditions including:

  • make:listener use class_exists() and unable to be tested
  • make:model with --resource or --api will ask to create the model again, this doesn't occur on normal operation.

crynobone and others added 5 commits September 13, 2023 21:11
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
@taylorotwell taylorotwell merged commit 33a206e into 10.x Sep 13, 2023
20 checks passed
@taylorotwell taylorotwell deleted the generator-test branch September 13, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants