[10.x] phpdoc: Auth\Access\Response constructor allows null message#48394
Merged
Conversation
Contributor
Author
|
It looks like it would be desirable to change constructor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Response::allow()andResponse::deny()constructResponsewith a null$message.However, the
Responseconstructor's phpdoc only allows string$message.Response::$messageis passed toAuthorizationException, so a null$messagecreates an Exception with the default messageThis action is unauthorized. However, an empty string$messagecreates an Exception with an empty string message.https://github.com/laravel/framework/blob/master/src/Illuminate/Auth/Access/AuthorizationException.php#L34
Solution
I modified Phpdoc to allow a null
$message.Users who get benefits from this
Users of static analysis tools (like PHPStan) would not encounter this error when using directly
new Response():