[10.x] Guess table name correctly in migrations if column's name have ('to', 'from' and/or 'in') terms

[i350]

This PR improves the table guesser, to work correctly if the user trying make migration that add/update/delete column have one of the terms ("to", "from" or/and "in")

For example, if the user executed the command

php artisan make:migration add_is_sent_to_3rd_party_service_column_to_users_table

The table name guesser before this update will return "3rd_party_service_column_to_users" as a table name, but after the update, it returns "users"

[hivokas]

I think we can just add .* in the beginning of the regex, so '/_(to|from|in)_(\w+)$/' becomes '/.*_(to|from|in)_(\w+)$/'. Based on my testing it also solves the issue and makes regex simpler.

[hivokas]

But better double check it before applying, maybe I missed something :)

[hivokas]

Overall thanks for PR, I think it's useful for cases like you described.

[jasonmccreary]

@i350, good catch on the bug here. I agree with @hivokas though, this regex could be a little simpler, for example:

    const CHANGE_PATTERNS = [
        '/.+_(to|from|in)_(\w+)_table$/',
        '/.+_(to|from|in)_(\w+)$/',
    ];

Given the greedy nature of regular expressions, this will force it to only match the "last" instance in the string. I quickly tried it with your new test cases in regex101. Feel free to update your PR and see if it works for you.

[i350]

Thanks @hivokas & @jasonmccreary

I just pushed an update to use the simplified regex you provided (52eac63)

[hivokas]

Thanks for your work @i350