Repository navigation
[10.x] Fixes GeneratorCommand not able to prevent uppercase reserved name such as __CLASS__ - #48667
Merged
Merged
Conversation
name such as `__CLASS__` Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
crynobone
marked this pull request as ready for review
October 8, 2023 12:11
timacdonald
pushed a commit
to timacdonald/framework
that referenced
this pull request
Oct 24, 2023
laravel#48667) name such as `__CLASS__` Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
binaryfire
added a commit
to hypervel/components-backup
that referenced
this pull request
Sep 10, 2026
Restore current Laravel tests for terminal PHP extension removal, view-name directory conversion, embedded extension preservation and case-insensitive reserved class names. Keep the separate Hypervel unit tests for generator behavior. Copy from Laravel 13.x at 01d008c9b5f32cb7c5e50a9a22273113d810b2a2 and adapt namespaces, Testbench, strict/native types and provider documentation. Preserve every upstream case and assertion. Additionally assert that reserved names create no class file, registering only that exact path for existing published-file cleanup. Relevant upstream history: laravel/framework#48667, laravel/framework#51842, laravel/framework#51847 and laravel/framework#51924. Verified the new test, combined generator and queue-route coverage, console integration tests and formatting. Generated files use the disposable Testbench application and existing cleanup lifecycle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.