[10.x] Optimize exists validation for empty array input - #48684
Merged
Conversation
mtawil
changed the title
exists validation for empty array inputexists validation for empty array input
timacdonald
pushed a commit
to timacdonald/framework
that referenced
this pull request
Oct 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a minor efficiency issue in the
existsvalidation method.Previously, an unnecessary SQL query was executed when validating an empty array:
The added check for a zero
$expectedvalue now bypasses this query, saving resources while keeping the intended validation behavior.