[10.x] Allow creation of PSR request with merged data #48696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timacdonald
force-pushed
the
http-message-bridge
branch
from
93bfd0a
to
83f8ff9
Compare
That was #47834 and basically |
timacdonald
force-pushed
the
http-message-bridge
branch
from
b12f703
to
10da1dc
Compare
timacdonald
commented
Oct 11, 2023
| "symfony/http-foundation": "^6.2", | ||
| "symfony/http-foundation": "^6.3", |
There was a problem hiding this comment.
Request::getPayload method is only available from 6.3.
timacdonald
commented
Oct 11, 2023
driesvints
approved these changes
Oct 13, 2023
timacdonald
added a commit
to timacdonald/framework
that referenced
this pull request
Oct 24, 2023
* Allow creation of PSR request with merged data * Add dependencies to require-dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a breaking change, for us, in
symfony/psr-http-message-bridge(symfony/psr-http-message-bridge#122) that means merged data for JSON requests is no longer added to the PSR request.The original PR was a fix for a different Laravel issue (although I'm not entirely sure what as the issue tracker for that repo is no longer visible).
fixes #48626