[10.x] Show CliDumper source content on last line #48707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebdw
changed the title
|
@taylorotwell @driesvints While I don't agree with this change, I wanted to get your opinion on it. So, I've asked @calebdw to submit a PR individually, so we can also get your opinion on this. Personally, I think while it does help solve the situation where the output of a Note: coding-wise, the pull request is OK. 
|
nunomaduro
requested review from
taylorotwell and
driesvints
and removed request for
nunomaduro
|
I think the before is fine really. |
|
I think I like this overall. |
timacdonald
pushed a commit
to timacdonald/framework
that referenced
this pull request
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Description
Please see #47514 for previous discussion.
This PR moves the CliDumper source content output from the first line to the last (non-empty) line.
Motivation
Showing the source output on the first line works for relatively small output (compared to the display height). However, a flaw is noticed as soon as the output significantly exceeds the display---a user is forced to scroll through all the lines just find the source or must resort to other means to track down the dump location in the codebase (such as redirecting stdout to a file and then viewing the head of the file). In essence, the convenience of locating the source with the content is lost for large outputs. Moving the source to the last line rectifies this and maintains the developer experience regardless of the dump size.
Screenshots
Before
After
Tag: @nunomaduro
Thanks!