[10.x] Fix duplicate conditions on retrying SELECT calls under createOrFirst()#48725
Merged
taylorotwell merged 2 commits intolaravel:10.xfrom Oct 16, 2023
Merged
[10.x] Fix duplicate conditions on retrying SELECT calls under createOrFirst()#48725taylorotwell merged 2 commits intolaravel:10.xfrom
SELECT calls under createOrFirst()#48725taylorotwell merged 2 commits intolaravel:10.xfrom
Conversation
Contributor
Author
I checked the existing implementations, but I couldn't find any parts that seemed to be affected. If you have any ideas please let me know. I'll try to fix it. |
Contributor
|
This is exactly how I thought I'd attempt it.👍 |
Contributor
|
lgtm! |
GrahamCampbell
changed the title
SELECT calls under createOrFirst()SELECT calls under createOrFirst()
timacdonald
pushed a commit
to timacdonald/framework
that referenced
this pull request
Oct 24, 2023
…ateOrFirst()` (laravel#48725) * fix: duplicate conditions with `firstOrCreate` and `createOrFirst` * fix: missing mocks due to additional code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #48718
fix: duplicate conditions with
firstOrCreateandcreateOrFirstThis is a fix as mentioned in [Known Issue] Duplicate conditions on retrying
SELECTcalls undercreateOrFirst()#48718. It is also the same process as anotherfirstOrCreate()that did not cause any problems.fix: missing mocks due to additional code
Adding
clonecaused some of the existing tests to fail. This is simply a test fix, as the mocks were no longer sufficient.