Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10.x] Extend Test Coverage for Str::take Function #48728

Merged
merged 1 commit into from Oct 16, 2023
Merged

[10.x] Extend Test Coverage for Str::take Function #48728

merged 1 commit into from Oct 16, 2023

Conversation

salehhashemi1992
Copy link
Contributor

@salehhashemi1992 salehhashemi1992 commented Oct 14, 2023 •
edited

Extend the test coverage for the Str::take function to include additional edge cases.

Tests that are added

  • test for $limit = 0
  • test for an empty string as $string
  • test for $limit > strlen($string)
  • test for $limit = strlen($string)
  • test for multi-byte characters in $string

@salehhashemi1992 salehhashemi1992 marked this pull request as ready for review October 14, 2023 20:02
@taylorotwell taylorotwell merged commit cdcb9ca into laravel:10.x Oct 16, 2023
21 checks passed
timacdonald pushed a commit to timacdonald/framework that referenced this pull request Oct 24, 2023
@salehhashemi1992 @timacdonald
extend Str::take function tests (laravel#48728)
0c29653
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@salehhashemi1992 @taylorotwell