Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.x] Match service provider after resolved #48824

Merged
merged 1 commit into from Oct 26, 2023

Conversation

timacdonald
Copy link
Member

The application's afterResolved callback receives the instance and the app.

The service provider's callAfterResolving helper also receives the instance and the app.

$this->app->afterResolving($name, $callback);
if ($this->app->resolved($name)) {
$callback($this->app->make($name), $this->app);
}

This changes means that the facade's version matches those.

Log::resolved(function (LogManager $log, Application $app) {
    //
});

@timacdonald timacdonald changed the title Match service provider after resolved [10.x] Match service provider after resolved Oct 26, 2023
@taylorotwell taylorotwell merged commit f54b5e0 into laravel:10.x Oct 26, 2023
21 checks passed
@timacdonald timacdonald deleted the resolving branch October 26, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants