[10.x] fix(Eloquent/Builder): calling the methods on passthru base object should be case-insensitive

[luka-papez]

fix(Eloquent/Builder): calling the methods on passthru base object should be case-insensitive

Fixes: #48825

The fix is quite straightforward: when deciding if the method called should be proxied to the base Builder object, compare the lowercased name of the method being called instead of the raw name.

There is an alternative proposal for a more robust solution in the linked Github issue, but I only saw the discussion after committing.

[bertoost]

This will break existing $passthru lists which has correct casing. The list should be compared lowercased as well.

I have extended the Query Builder, and configured toSql to passthru, but it suddenly breaks (and returns the Builder instead) because of this casing. Once I lowercased the $passthru list, it worked again.

This should work;

if (in_array(strtolower($method), array_map('strtolower', $this->passthru))) {
    // ...
}

[luka-papez]

Hi @bertoost

I didn't get notified about your comment, most likely because the issue is closed. I suspect the maintainers didn't get notified either.

I see the problem, I did wonder if lowercasing the $passthru property would break someone's code and inevitably it did 🙈

The fix you proposed sounds reasonable to me - I think you should go ahead an open a pull request, the maintainers are very responsive and will gladly merge it in. If you need help, feel free to ping me here, I will subscribe to the thread.