Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10.x] Use HtmlString in Vite fake #49163

Merged
merged 2 commits into from Nov 28, 2023
Merged

[10.x] Use HtmlString in Vite fake #49163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4151da4
use htmlstring
jasonvarga Nov 28, 2023
6f9671c
test
jasonvarga Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Illuminate/Foundation/Testing/Concerns/InteractsWithContainer.php
View file
Open in desktop
Expand Up @@ -117,7 +117,7 @@ protected function withoutVite()
{
public function __invoke($entrypoints, $buildDirectory = null)
{
return '';
return new HtmlString('');
}

public function __call($method, $parameters)
Expand Down
2 changes: 1 addition & 1 deletion tests/Foundation/Testing/Concerns/InteractsWithContainerTest.php
View file
Open in desktop
Expand Up @@ -13,7 +13,7 @@ public function testWithoutViteBindsEmptyHandlerAndReturnsInstance()
{
$instance = $this->withoutVite();

$this->assertSame('', app(Vite::class)(['resources/js/app.js']));
$this->assertSame('', app(Vite::class)(['resources/js/app.js'])->toHtml());
$this->assertSame($this, $instance);
}

Expand Down