[10.x] Database layer fixes#49787
Merged
taylorotwell merged 1 commit intolaravel:10.xfrom Apr 15, 2024
saadsidqui:database_layer_fixes
Merged
[10.x] Database layer fixes#49787taylorotwell merged 1 commit intolaravel:10.xfrom saadsidqui:database_layer_fixes
taylorotwell merged 1 commit intolaravel:10.xfrom
saadsidqui:database_layer_fixes
Conversation
|
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
… BackedEnums - Illuminate\Database\Eloquent\Relations\BelongsTo::getForeignKeyFrom() handles BackedEnums properly See #49735
driesvints
approved these changes
Jan 23, 2024
Member
driesvints
left a comment
driesvints
left a comment
There was a problem hiding this comment.
All in all I can see nothing wrong with this PR. Thanks 👍
Contributor
Author
|
@taylorotwell sorry I'm confused as to why the PR was reverted to a draft. If there are any comments or suggestions I'll be happy to contribute the fixes. |
Contributor
Author
|
@driesvints any idea what else is needed here? I'm very confused. |
Member
|
Hi @sidquisaad. Most likely Taylor is too busy rn to review and will review at a later moment. Thanks! |
Member
|
@taylorotwell gonna mark this ready for you again if that's okay. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a couple of issues discussed in #49735 .
Appropriate checks are added to
Illuminate\Database\Eloquent\Relations\BelongsTo::getForeignKeyFrom()andIlluminate\Database\Query\Builder::whereIntegerInRaw()to return the proper value if aBackedEnumis encountered. This is typically the case on models where a cast has been defined, especially on keys.I have also added a couple of tests to cover these cases where it seemed appropriate.
There might be other similar cases. Please see this comment.