[10.x] Expose queue name and delay on job queue events #49833
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stayallive
force-pushed
the
add-data-to-queue-events
branch
from
88391a7
to
6deeaef
Compare
|
Can you send this change to master? Because I think queue name should be taken in the constructor right after connection so the order is more logical. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add the
queueanddelayproperty to theJobQueueingandJobQueuedevents.Why?
With the introduction of the
JobQueueing(#49722) we can now profile what is happening in the application when a job is being queued (for example: getsentry/sentry-laravel#833), however we only know the queue connection and job name.It is also useful to know which queue and with what delay a job was queued since they are already available where the events are dispatched I "simply" added them to the event.