[10.x] Fix DB::afterCommit() broken in tests using DatabaseTransactions - #50068
Merged
Conversation
Member
|
Thanks @oprypkhantc. Appreciate the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #50066
Currently, committing the "root" transaction causes
DatabaseTransactionsManagerto remove all$pendingTransactions. This tells theDatabaseTransactionsManagerthat it's outside of the transaction and makes it immediately execute callbacks on calls toDB::afterCommit():Outside of tests, this works as expected.
In tests that use
DatabaseTransactionstrait however, this causes an issue whenever you have a commit inside of your test:This PR fixes this by not letting
commit()remove a pending transaction of a lower level than what's being committed. The result is that committing a nested transaction in tests leaves the root$pendingTransactionsin place.Please let me know if we need more tests or explanations for this. Feel free to make changes on the branch.