Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10.x] Remove use mysql database #50358

Closed
wants to merge 1 commit into from
Closed

[10.x] Remove use mysql database #50358

wants to merge 1 commit into from

Conversation

hughcube
Copy link

@hughcube hughcube commented Mar 4, 2024 •
edited
Loading

The DSN information of pdo already contains the information of the default database, so there is no need to emphasize it again.

@hughcube
Remove use database
db2a412 
The DSN information of pdo already contains the information of the default database, so there is no need to emphasize it again.
@hughcube hughcube changed the title Remove use database [10.x]Remove use database Mar 4, 2024
@hughcube hughcube changed the title [10.x]Remove use database Remove use mysql database Mar 4, 2024
@driesvints
Copy link
Member

This could be for "sphinx" database (unofficial) support: #14225

Also follow up PR here: #13701

@driesvints driesvints changed the title Remove use mysql database [10.x] Remove use mysql database Mar 4, 2024
GrahamCampbell
GrahamCampbell requested changes Mar 4, 2024
View reviewed changes
Copy link
Member

@GrahamCampbell GrahamCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is incorrect. It's possible to re-use connections across multiple databases if persistent connections are enabled. It's essential we always run this within the connector.

@GrahamCampbell
Copy link
Member

GrahamCampbell commented Mar 4, 2024 •
edited
Loading

Moreover, I know that the database name is not actually sent to the database if configured in the usual way, having recently been watching the raw packets going back and forth, when trying to reduce the number of round trips.

@GrahamCampbell
Copy link
Member

If this is for compatibility with some obscure database, the best thing is almost certainly a third party package for supporting it, IMO.

@driesvints
Copy link
Member

Yeah, don't think we're gonna merge this one in sorry. Thanks @GrahamCampbell

@driesvints driesvints closed this Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrahamCampbell GrahamCampbell GrahamCampbell requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hughcube @driesvints @GrahamCampbell