Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: phpstan issue - right side of || always false #50453

Merged
merged 1 commit into from Mar 12, 2024

Conversation

Carnicero90
Copy link
Contributor

isset already checks if the value is null (and phpstan complains about that).

In addition, please describe the benefit to end users; the reasons it does not break any existing features; how it makes building web applications easier, etc.

No real benefit to anybody, it doesn't break any existing feature since the condition that should be removed was always false, won't make building web applications easier. I just noticed that minor issue, hence my pr.

@taylorotwell taylorotwell merged commit f1fb9a6 into laravel:10.x Mar 12, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants