Skip to content

Conversation

@Carnicero90
Copy link
Contributor

isset already checks if the value is null (and phpstan complains about that).

In addition, please describe the benefit to end users; the reasons it does not break any existing features; how it makes building web applications easier, etc.

No real benefit to anybody, it doesn't break any existing feature since the condition that should be removed was always false, won't make building web applications easier. I just noticed that minor issue, hence my pr.

@taylorotwell taylorotwell merged commit f1fb9a6 into laravel:10.x Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants