Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10.x] Fix Collection::concat() return type #50669

Merged
merged 1 commit into from Mar 20, 2024
Merged

[10.x] Fix Collection::concat() return type #50669

merged 1 commit into from Mar 20, 2024

Conversation

axlon
Copy link
Contributor

@axlon axlon commented Mar 20, 2024 •
edited

This PR fixes the return type of Collection::concat() and LazyCollection::concat().

Collection::make([1])->concat(['foo']);

Before:

Collection<int, int>

After:

Collection<int, int|string>

nunomaduro
nunomaduro requested changes Mar 20, 2024
View reviewed changes
Copy link
Member

@nunomaduro nunomaduro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update Illuminate\Support\Enumeration?

@axlon axlon force-pushed the collection-concat-types branch 2 times, most recently from 5b6d2c8 to 41c3a4e Compare March 20, 2024 17:26
@axlon axlon requested a review from nunomaduro March 20, 2024 17:37
@taylorotwell taylorotwell merged commit 9f26b84 into laravel:10.x Mar 20, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunomaduro nunomaduro nunomaduro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@axlon @nunomaduro @taylorotwell