[11.x] Binding order is incorrect when using cursor paginate with multiple unions with a where #50795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thijsvdanker
changed the title
thijsvdanker
changed the title
This is necessary to allow cursor pagination to add a where binding to the right union query.
|
I've implemented the first solution in this PR. |
driesvints
changed the title
|
@thijsvdanker if this is a bug fix it should ideally go to 10.x |
|
Please send this to 10.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
cursorPaginateon a query that has multiple unions, the binding order is incorrect.This happens because:
https://github.com/laravel/framework/blob/11.x/src/Illuminate/Database/Concerns/BuildsQueries.php#L436
adds the bindings for the cursor
whereto the end of the bindings and not in the position that they should be.The result is a query that binds the wrong values to the wrong parameters in the query.
Possible solutions I can now think of are:
uniona nested array until the bindings are resolved to make the query and add the cursor bindings to the right indexunionbindings after adding the cursor bindings