New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[11.x] Use Default Schema Name on SQL Server #50855
Merged
taylorotwell
merged 22 commits into
laravel:11.x
from
hafezdivandari:11.x-get-default-schema-sqlsrv
Apr 1, 2024
Merged
[11.x] Use Default Schema Name on SQL Server #50855
taylorotwell
merged 22 commits into
laravel:11.x
from
hafezdivandari:11.x-get-default-schema-sqlsrv
Apr 1, 2024
+60
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50842
On SQL Server,
Schema
methods were always usingdbo
schema as default. This causes problem in a rare condition that user manually changes the default schema (e.g by callingalter user my_user with default_schema = my_schema
). This PR fixes that by utilizing the actual default schema (not alwaysdbo
).